Skip to content

Reduce log noise#16879

Merged
lucylq merged 1 commit intomainfrom
lfq.reduce-log-noise
Jan 26, 2026
Merged

Reduce log noise#16879
lucylq merged 1 commit intomainfrom
lfq.reduce-log-noise

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Jan 26, 2026 •
edited
Loading

copy of #16877 ..

@lucylq lucylq requested a review from JacobSzwejbka as a code owner January 26, 2026 18:29
Copilot AI review requested due to automatic review settings January 26, 2026 18:29
@lucylq lucylq requested a review from larryliu0820 as a code owner January 26, 2026 18:29
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 26, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16879

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Pending, 1 Unrelated Failure

As of commit b0f8c46 with merge base b729d35 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2026
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise by simplifying an error message that previously included potentially large binary buffer data. The change removes the actual buffer contents from the ValueError message when duplicate keys with different data are detected, keeping only the key identifier.

Changes:

  • Simplified error message in NamedDataStore to exclude potentially large binary buffer data while retaining the duplicate key name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lucylq lucylq force-pushed the lfq.reduce-log-noise branch from 5521430 to b0f8c46 Compare January 26, 2026 18:35
@lucylq lucylq merged commit f7dfcf4 into main Jan 26, 2026
168 of 170 checks passed
@lucylq lucylq deleted the lfq.reduce-log-noise branch January 26, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kirklandsign kirklandsign kirklandsign approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucylq @kirklandsign